Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model and tests: conversion tag, conversion event and pin #96

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

thucngyyen
Copy link
Contributor

@thucngyyen thucngyyen commented Mar 29, 2023

  • Conversion tag: no new field and add more test d98d6cb
  • Conversion event: new custom_data and update test with this field c23048f
  • Pin: add support for ad_account_id and update test 09ab5f5

@thucngyyen thucngyyen temporarily deployed to integ March 29, 2023 22:06 — with GitHub Actions Inactive
@thucngyyen thucngyyen temporarily deployed to integ March 29, 2023 22:06 — with GitHub Actions Inactive
@rushabhvaria rushabhvaria merged commit 251bece into feature-fix/tests Mar 29, 2023
rushabhvaria pushed a commit that referenced this pull request Mar 30, 2023
* Update conversion tag

* Update conversion event

* Update pin model
@rushabhvaria rushabhvaria deleted the feature-dev/thuc-fix branch April 6, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants