Update variable name substitution logic #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
approved these changes
Jan 3, 2019
There was a problem hiding this comment.
Looks good to me.
@rahul-malik Maybe would be good to add a unit test / example case though that catches this cases?
- Account for names that would conflict with ARC (prefix is "alloc", "new", ... ) - Add test fixture for to guarantee compilation
rahul-malik
force-pushed
the
rmalik-variable-sub-fixes
branch
from
d10394d
to
2120649
Compare
|
@maicki - Updated:
|
|
Fixes #138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"new", ... )
"percent", ...)
TODO: This is a shorter term patch and we should strive to have a more
robust substitution policy across languages.