Conditionally format values for matching #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously always string-ified syscall values in preparation for filtering them with 'match' checkers. This isn't the behavior we want for 'byte' and 'byterray' values, however, because we'd end up matching against their `__str__` representations (e.g. `bytearray(b'abc')`). We now only format the value when it isn't one of (bytes, bytearray, str), and we require the matcher to be bytes- or string-aware. (This is something we could consider revisiting by attempting to decode bytes to strings, to make matching more natural, but I don't know if that level of implicit conversion is really needed for such a low-level library.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously always string-ified syscall values in preparation for
filtering them with 'match' checkers. This isn't the behavior we want
for 'byte' and 'byterray' values, however, because we'd end up matching
against their
__str__representations (e.g.bytearray(b'abc')).We now only format the value when it isn't one of (bytes, bytearray,
str), and we require the matcher to be bytes- or string-aware. (This is
something we could consider revisiting by attempting to decode bytes to
strings, to make matching more natural, but I don't know if that level
of implicit conversion is really needed for such a low-level library.)
Fixes #7