-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicode character in key not detected if python2 str #117
Comments
I think what's happening is that python2 is reporting that key as a if isinstance(key, six.text_type):
try:
key = key.encode('ascii')
except UnicodeEncodeError:
raise MemcacheIllegalInputError("Non-ASCII key: '%r'" % (key,)) What is going on is that python2 str is not caught in {{six.text_type}} ([here is the documentation|https://pythonhosted.org/six/#six.text_type] so the check doesn't happen. (we weren't the only ones |
Going to write a PR to fix this. |
nichochar
pushed a commit
that referenced
this issue
Oct 3, 2016
nichochar
added a commit
that referenced
this issue
Oct 3, 2016
Fix #117, illegal unicode character in middle of key (or value now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
User tried to use key
'rpgv:https://www.pacificsales.com/brands/viking?ref=166_725&loc=soc_\xb1901520_%c3%abuy!'
and noMemcacheIllegalInputError
was raised, which causes obsure bug with stack trace belowThe text was updated successfully, but these errors were encountered: