Allow the pool lock to be specialized #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be quite useful to allow the lock that the pool uses to be specified to be something other than the default threading lock class/type. This can be especially useful when eventlet (or gevent or other) are used which have there own special lock type that connects into there event-loop.
| max_pool_size=None): | ||
| max_pool_size=None, | ||
| # Allow this to be a different style of lock (eventlet | ||
| # lock/semaphore for example, that works with greenthreads). |
There was a problem hiding this comment.
This type of documentation generally goes in a docblock.
There was a problem hiding this comment.
Ya. I'll add those into a docstring/block on the class.
|
This is pretty nit-picky, but we've been using the Google style guide for documentation, and I have a mild preference that we stay consistent with that: https://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Comments#Comments |
|
Apologies! I lost track of this change, merging now.. |
cgordon
added a commit
that referenced
this pull request
May 11, 2015
Allow the pool lock to be specialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be quite useful to allow the lock that the pool
uses to be specified to be something other than the default
threading lock class/type. This can be especially useful when
eventlet (or gevent or other) are used which have there own
special lock type that connects into there event-loop.