Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private DataDoc to search functionality #217

Closed
ldziko opened this issue Aug 25, 2020 · 0 comments · Fixed by #232
Closed

Add private DataDoc to search functionality #217

ldziko opened this issue Aug 25, 2020 · 0 comments · Fixed by #232

Comments

@ldziko
Copy link
Contributor

ldziko commented Aug 25, 2020

Currently, all private DataDocs are not indexed on Elasticsearch for simplification of logic. Since most of the DataDocs will be private by default with FGAC, it is essential to make them searchable from Elasticsearch. The new Elasticsearch table for DataDocs should include 2 more fields: public and readable_user_ids. The second field readable_user_ids should include every user who can access this private DataDoc.

@ldziko ldziko self-assigned this Aug 25, 2020
@ldziko ldziko linked a pull request Aug 31, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant