Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add disabled indicators to Schedules list #1122

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

baumandm
Copy link
Contributor

@baumandm baumandm commented Jan 9, 2023

This PR provides some visual cues for disabled schedules in the Schedules list:

  • Shows Next Run: Disabled instead of the would-be timestamp (if it was enabled)
  • The DataDoc name heading is lightened

Screenshot 2023-01-09 at 16-34-18 Querybook

Copy link
Collaborator

@czgu czgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@czgu czgu merged commit d059a7a into pinterest:master Jan 9, 2023
@baumandm baumandm deleted the external/disabled-schedules branch January 10, 2023 00:20
rohan-sh1 pushed a commit to CAI-TECHNOLOGIES/cai-ext-db-explorer that referenced this pull request Feb 28, 2023
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants