Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update querybook helm charts #1147

Merged
merged 2 commits into from
Feb 17, 2023
Merged

update querybook helm charts #1147

merged 2 commits into from
Feb 17, 2023

Conversation

okayhooni
Copy link
Contributor

  • add ingress template to make http/https endpoint on webserver component
  • add extraEnv props. to inject common environment variables to all the pods of components
  • fix pod assigning configs on values.yaml to valid position (all the pod templates actually has same global configs)

czgu
czgu reviewed Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@czgu czgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there any particular reason you are changing port to 8081 instead of 10001? would this break anyone using the previous version?

@okayhooni
Copy link
Contributor Author

LGTM, is there any particular reason you are changing port to 8081 instead of 10001? would this break anyone using the previous version?

this container port change was related to our specific k8s setup. but it works well without any side-effect.

I made this target container port to templated value with default = 10001

@czgu czgu merged commit 2590382 into pinterest:master Feb 17, 2023
rohan-sh1 pushed a commit to CAI-TECHNOLOGIES/cai-ext-db-explorer that referenced this pull request Apr 11, 2023
@okayhooni @rohan-sh1
update querybook helm charts (pinterest#1147)
cd88cfa 
* update querybook helm charts

* container target port was templated

---------

Co-authored-by: ok9897 <ok9897@krafton.com>
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
@okayhooni @aidenprice
update querybook helm charts (pinterest#1147)
c5424f6 
* update querybook helm charts

* container target port was templated

---------

Co-authored-by: ok9897 <ok9897@krafton.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgu czgu czgu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@okayhooni @czgu