feat: add estimated time for query execution #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jczhong84
reviewed
Feb 10, 2023
| moment.duration(secondsRemainToComplete, 'seconds') | ||
| )} | ||
| . | ||
| </div> |
There was a problem hiding this comment.
would prefer to format the string first to avoid the weird {' '}, e.g.
message = `Estimated to be completed in ${formatDuration(moment.duration(secondsRemainToComplete, 'seconds'))}.`
<div>{message}</div>
jczhong84
reviewed
Feb 10, 2023
| contentDOM = ( | ||
| <div className="statement-execution-text-container"> | ||
| <div className="statement-execution-text-title"> | ||
| Status: {statusLabel} | ||
| </div> | ||
| {getMetaInfoDOM()} | ||
| {progressBar} | ||
| {estimatedTimeDOM} |
There was a problem hiding this comment.
how about display the estimation in the same line with progress bar, after the %, like
[>>>>.........] 25% (Estimated to be completed in 14s)
or just
[>>>>.........] 25% ( 14s remaining)
jczhong84
approved these changes
Feb 10, 2023
czgu
added a commit
to czgu/querybook
that referenced
this pull request
Feb 15, 2023
This reverts commit 7a25679.
czgu
added a commit
that referenced
this pull request
Feb 15, 2023
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Apr 11, 2023
* feat: add estimated time for query execution * resolved comments
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Apr 11, 2023
pinterest#1166) This reverts commit 7a25679.
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* feat: add estimated time for query execution * resolved comments
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
pinterest#1166) This reverts commit 7a25679.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a linear interpolation on how long the query would finish