feat: toggle run all notifications #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
Feb 14, 2023
| @@ -381,26 +381,32 @@ def run_data_doc(id): | |||
|
|
|||
|
|
|||
| @register("/datadoc/<int:id>/run/", methods=["POST"]) | |||
| def adhoc_run_data_doc(id): | |||
| def adhoc_run_data_doc(id, sendNotification=True): | |||
There was a problem hiding this comment.
use camel casing send_notifications
also please default it as False
|
|
||
| interface IProps { | ||
| defaultNotification: boolean; | ||
| handleNotificationChange: (notification: boolean) => void; |
| const [notification, setNotification] = useState(defaultNotification); | ||
|
|
||
| const internalNotificationChange = useCallback( | ||
| (value) => { |
| onChange={internalNotificationChange} | ||
| /> | ||
|
|
||
| <span data-balloon-pos={'up'} className="ml4"> |
There was a problem hiding this comment.
data-balloon-pos={'up'}
but there is no tooltip to show?
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Apr 11, 2023
* feat: toggle run all notifications * chore: rename var change default send notification * fix: rename all handleNotificationChange
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* feat: toggle run all notifications * chore: rename var change default send notification * fix: rename all handleNotificationChange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a toggle to the run all confirmation page so that users can choose whether they want a notification to be sent upon run completion. By default, the notification and toggle will be enabled to match previous behavior of Querybook where a notification will always be sent to the user upon run completion. The type of notification sent is still based on "notification preference" in user settings.