feat: create data element along with syncing table #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
537
to
540
| def get_data_element(self, data_element_name: str) -> DataElementTuple: | ||
| """Override this to get data element by name""" | ||
| return None | ||
|
|
There was a problem hiding this comment.
is this needed ? If yes, the return type should be a tuple or none ?
suryabhaskarkarri
approved these changes
Mar 9, 2023
| @@ -534,9 +534,9 @@ def get_table_and_columns( | |||
| """ | |||
| pass | |||
|
|
|||
| def get_data_element(self, data_element_name: str) -> DataElementTuple: | |||
| def get_data_element(self, data_element_name: str) -> Optional[DataElementTuple]: | |||
There was a problem hiding this comment.
@AbstractMethod is also needed ?
There was a problem hiding this comment.
Please check this before landing
There was a problem hiding this comment.
didn't add AbstractMethod on purpose, for people they dont have data element, they dont have to implement this function.
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Apr 11, 2023
* feat: create data element along with syncing table * comment
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* feat: create data element along with syncing table * comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When syncing a table, we'll create or update the data element if we find any data elements associated with any columns.