feat: add stats logging #1204
Merged
feat: add stats logging #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jczhong84
force-pushed
the
feat/statslogger
branch
from
176adb0
to
449bd3c
Compare
czgu
reviewed
Mar 27, 2023
| @@ -56,6 +61,11 @@ def wrapper(fn): | |||
| @flask_app.route(r"%s%s" % (DS_PATH, url), methods=methods) | |||
| @functools.wraps(fn) | |||
| def handler(**kwargs): | |||
| # increment the number of api request counter | |||
| stats_logger.incr(API_REQUEST_COUNTER.format(fn.__name__)) | |||
There was a problem hiding this comment.
should we use the url here? it is generic right
There was a problem hiding this comment.
url is something like /query_execution/<int:query_execution_id>/, which will include the parameter types.
czgu
approved these changes
Mar 31, 2023
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Apr 11, 2023
* feat: add stats logging * comments
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* feat: add stats logging * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding stats logging support.
Metrics: