feat: add data elements to ES index #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jczhong84
commented
Apr 5, 2023
jczhong84
commented
- Add below metadata to elastic search index
- data element names
- column description
- data element description
- Add the filter for data elements on search table tab
czgu
reviewed
Apr 5, 2023
querybook/webapp/components/DataElement/DataElementGroupSelect.tsx
Outdated
Show resolved
Hide resolved
querybook/webapp/components/DataElement/DataElementGroupSelect.tsx
Outdated
Show resolved
Hide resolved
czgu
previously approved these changes
Apr 6, 2023
| @@ -26,3 +26,8 @@ export function useRankedTags(tags: ITag[]) { | |||
| [tags] | |||
| ); | |||
| } | |||
|
|
|||
| export function isTagValid(val: string) { | |||
There was a problem hiding this comment.
put it under lib/utils/tag.ts?
| placeholder?: string; | ||
| onSelect?: (entity: string) => void; | ||
| onEntitiesChange?: (entities: string[]) => void; | ||
| isEntityValid?: (entity: string) => boolean; |
czgu
approved these changes
Apr 6, 2023
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Apr 11, 2023
* feat: add data elements to ES index * fix unit test and address comments * remove unused property * cover all TableTagSelect cases * comments
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* feat: add data elements to ES index * fix unit test and address comments * remove unused property * cover all TableTagSelect cases * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.