fix: Ensure meta_info is updated when an exception occurs #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jczhong84
approved these changes
Apr 26, 2023
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, if a Trino query fails fast enough that the
poll()function never runs successfully, themeta_infofor the execution won't be captured, containing the Trino tracking URL. Something like "asdfg" as a query would trigger this because Trino doesn't need to do any metastore lookups before failing the query. Whereas queries that are slower to fail will go through 2 or more poll() iterations, and the successful ones will update the meta_info prior to the exception.This PR fixes the issue by catching exceptions and updating the tracking URLs, as well as ensuring that on_statement_update() get a copy of meta_info when an exception occurs during the first poll()