feat: add data elements to demo #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
czgu
commented
Apr 22, 2023
czgu
commented
- also fixed some issues with string data element
- added tags and data element in demo
- hide data element search if it is not available
jczhong84
reviewed
Apr 22, 2023
Comment on lines
+135
to
+143
| data_element = None | ||
| if data_element_tuple: | ||
| if type(data_element_tuple) is str: | ||
| data_element = get_data_element_by_name(data_element_tuple, session=session) | ||
| elif data_element_tuple.name and data_element_tuple.type: | ||
| data_element = create_or_update_data_element( | ||
| metastore_id, data_element_tuple, session=session | ||
| ) | ||
|
|
There was a problem hiding this comment.
does it need to check the data_element is None again here?
There was a problem hiding this comment.
i added a check on line 148
Comment on lines
+353
to
+355
| queryMetastores.find((metastore) => metastore.id === metastoreId); | ||
| const queryMetastoreHasDataElements = | ||
| !!queryMetastore?.flags?.has_data_element; |
There was a problem hiding this comment.
nit: queryMetastores.some((metastore) => metastore.id === metastoreId && !!metastore.flags?.has_data_element)
There was a problem hiding this comment.
i think its better to find the queryMetastore first and then check if it has data elements. Using some make the logic harder to understand and less extensible
jczhong84
approved these changes
Apr 24, 2023
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* feat: add data elements to demo * resolved comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.