Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add data element on the sidebar, show descriptions #1233

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

czgu
Copy link
Collaborator

@czgu czgu commented Apr 24, 2023

filter by data element on the sidebar
image

data element now also displays description (2 lines at most):
image

image

@czgu czgu requested a review from jczhong84 April 24, 2023 18:58
querybook/webapp/stylesheets/_utilities.scss Outdated Show resolved Hide resolved
}

type StringOrWithDescription =
| string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this extra | here for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its the prettier formating

@czgu czgu merged commit 0e79d74 into pinterest:master Apr 24, 2023
4 checks passed
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
)

* feat: add data element on the sidebar, show descriptions

* resolved comment style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants