feat: add error handling and use EventSource for AI assistant #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jczhong84
commented
Jun 10, 2023
jczhong84
commented
- send errors through the event stream and show it on frontend with toast
- adopted the SSE stream format
- using EventSource on frontend to better handling the stream, instead of fetch
jczhong84
changed the title
jczhong84
changed the title
czgu
reviewed
Jun 12, 2023
| return func(self, *args, **kwargs) | ||
| except Exception as e: | ||
| LOG.error(e, exc_info=True) | ||
| callback_handler = kwargs.get("callback_handler") |
There was a problem hiding this comment.
callback_handler is required, can you make it more explicit (not just in except)
it would be useful to note that callback_handler must be passed as kwargs not args
There was a problem hiding this comment.
actually callback_handler is not always required, only when it's a streaming function. and catch_error will also handle non streaming functions as well. will update
czgu
reviewed
Jun 12, 2023
czgu
approved these changes
Jun 12, 2023
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
…est#1265) * feat: add error handling and use EventSource * fix linter * address comments * raise from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.