fix: only handle the query generation keydown event when not streaming #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
Jun 27, 2023
| /> | ||
| </div> | ||
| ) : ( | ||
| fixedQuery && ( |
There was a problem hiding this comment.
replace with streamStatus === StreamStatus.DONE && ?
There was a problem hiding this comment.
it doesn't always have the fixedQuery when the streaming is done. for those cases, we dont want to show the apply/cancel buttons
| if (matchKeyPress(event, 'Enter')) { | ||
| if ( | ||
| streamStatus !== StreamStatus.STREAMING && | ||
| matchKeyPress(event, 'Enter') |
There was a problem hiding this comment.
can you also make the textbox not editable while streaming?
czgu
approved these changes
Jun 27, 2023
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
pinterest#1287) * fix: only handle the query generation keydown event when not streaming * add cancel stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support of streaming cancellation
also only handle the query generation keydown event when not streaming