Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: comment ui updates #1295

Merged
merged 4 commits into from
Jul 17, 2023
Merged

ui: comment ui updates #1295

merged 4 commits into from
Jul 17, 2023

Conversation

meowcodes
Copy link
Contributor

Screenshot 2023-07-14 at 11 41 48 AM Screenshot 2023-07-14 at 11 17 30 AM Screenshot 2023-07-14 at 11 17 24 AM

have cursor:pointer when hovering over reactions
make the input field get focused when it opens
add some shortcut to send message, maybe (shift+enter) for newline and enter to send?
add way cancel “Replying to” - when clicking on replying to again it would cancel the status
lower opacity when the clear and send button are disabled?
remove “replying to” when editing a reply
undo delete button
When adding a emoji, disable the button and/or show a loading status until it is added since it is async

@meowcodes meowcodes requested review from czgu and jczhong84 July 14, 2023 15:43
querybook/webapp/const/keyMap.ts Outdated Show resolved Hide resolved
querybook/webapp/ui/Comment/AddReactionButton.tsx Outdated Show resolved Hide resolved
querybook/webapp/ui/Comment/Comment.tsx Outdated Show resolved Hide resolved
querybook/webapp/ui/Comment/Comment.tsx Outdated Show resolved Hide resolved
querybook/webapp/ui/Comment/Comment.tsx Outdated Show resolved Hide resolved
querybook/webapp/ui/Comment/Reactions.tsx Show resolved Hide resolved
querybook/webapp/ui/Comment/Reactions.tsx Show resolved Hide resolved
@meowcodes meowcodes merged commit 78c84d5 into pinterest:master Jul 17, 2023
3 checks passed
@meowcodes meowcodes deleted the comment branch July 17, 2023 16:52
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants