Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add scroll bar to Query Engine Status popover #1353

Merged
merged 1 commit into from Nov 29, 2023

Conversation

baumandm
Copy link
Contributor

Environments with many Query Engines break the Query Engine status popover, so this PR adds a max-height and a scrollbar to keep everything on the screen.

Before: 馃樋
Screen Shot 2023-10-23 at 09 54 25-fullpage

After: 馃樃
Screen Shot 2023-10-23 at 09 54 42-fullpage

@czgu czgu merged commit f8d8dd4 into pinterest:master Nov 29, 2023
3 checks passed
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
@baumandm baumandm deleted the external/query-engine-status-scroll branch January 10, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants