Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ability to omit clean_up jobs from general db_clean task and fixed clean_up_archived_data_doc #1387

Merged
merged 1 commit into from Jan 3, 2024

Conversation

jij1949
Copy link
Contributor

@jij1949 jij1949 commented Dec 18, 2023

Now -1 can be passed into the run_all_db_clean_up_jobs task for each days_to_keep argument value. This will omit the specific db_clean_up tasks from being run. For example, if the value for days_to_keep_task_record is passed in as -1, then clean_up_task_run_record will not be run.

Previously, clean_up_archived_data_doc would not run properly and the logic meant that only non-archived datadocs would be deleted, which is the inverse of the intent of the function. This has been changed to only delete archived datadocs that have been updated more than days_to_keep ago

Copy link
Collaborator

@czgu czgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@czgu czgu merged commit 900d2d6 into pinterest:master Jan 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants