Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update unique_table_ownership constraint to allow owner per type #1403

Merged

Conversation

baumandm
Copy link
Contributor

This PR addresses a limitation of the Data Table Ownership type feature, which was previously added in #1170. That PR added a type column to support multiple types of owners per table. However, the unique constraint between data_table_id and uid prevents any user from having multiple types of ownership.

This PR adds a new database migration that updates the constraint to include the type column.

Screenshot 2024-01-31 at 2 03 11 PM

@jczhong84
Copy link
Collaborator

Thanks @baumandm for fixing it!

@jczhong84 jczhong84 merged commit 8531df1 into pinterest:master Feb 1, 2024
3 checks passed
@baumandm baumandm deleted the external/unique-table-ownership branch February 1, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants