Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update pip install command #1407

Merged
merged 1 commit into from Feb 5, 2024

Conversation

baumandm
Copy link
Contributor

@baumandm baumandm commented Feb 5, 2024

Previously, the pip install command in the Dockerfile ended in || true, so it never failed. I think the purpose was to make local.txt optional, but it also covers up any errors installing packages.

This removes || true and instead makes local.txt optional by checking to see if the file exists.

Copy link
Collaborator

@czgu czgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@czgu czgu merged commit 97d3473 into pinterest:master Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants