Add cluster namespace support #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywang282
reviewed
Aug 9, 2017
|
|
||
| public String getNamespace() { | ||
| return namespace; | ||
|
|
ywang282
reviewed
Aug 9, 2017
| if (namespace != null ? !namespace.equals(cluster.namespace) : cluster.namespace != null) | ||
| return false; | ||
| return name != null ? name.equals(cluster.name) : cluster.name == null; | ||
|
|
ywang282
reviewed
Aug 9, 2017
| public Response findTasks(@QueryParam("namespace") Optional<String> namespace, | ||
| @QueryParam("clusterName") Optional<String> clusterName, | ||
| @QueryParam("state") Optional<TaskState> state) { | ||
| List<Task> result = taskQueue.peekTasks(new Cluster(namespace.get(), clusterName.get()), | ||
| state.map(TaskState::intValue).orElse(null)); |
There was a problem hiding this comment.
what if namespace and clusterName is not set in the query parameter?
get(): If a value is present in this Optional, returns the value, otherwise throws NoSuchElementException.
There was a problem hiding this comment.
It should return all tasks.
will add some tests to verify
|
@ywang282 it's work in progress, i will let you know when it's ready to review |
shuzhang1989
force-pushed
the
cluster_richer_info
branch
from
dc75426
to
334241e
Compare
shuzhang1989
changed the title
jinruh
approved these changes
Aug 15, 2017
| * @author shu (shu@pinterest.com) | ||
| */ | ||
| public class Cluster { | ||
| public String namespace; |
| */ | ||
| public class Cluster { | ||
| public String namespace; | ||
| public String name; |
There was a problem hiding this comment.
also can we add some comments on what is namespace and what is name in the cluster?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a full stack change, motivation is to divide different clusters into namespace and cluster name. so realpin, rocksdb and scorpion will be 3 namespaces, and cluster name will be the next level in zk path.
Change list: