Add secor.max.active.files property to controll active file count #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdambrauskas
changed the title
| @@ -277,6 +277,10 @@ public long getMaxFileAgeSeconds() { | |||
| return getLong("secor.max.file.age.seconds"); | |||
| } | |||
|
|
|||
| public int getMaxActiveFiles() { | |||
| return getInt("secor.max.file.count", 100); | |||
There was a problem hiding this comment.
How about we set the default to -1, and on the caller side if getMaxActiveFiles returns -1 it will not forceUpload, this way we can maintain the backward compatible behavior for the installations who didn't face memory problem.
|
Looks good to me, I left a small comment in the code for backward compatible behavior. And I don't think we should sort the files since that would change the file uploading order, some people might not like that. |
pdambrauskas
force-pushed
the
add_max_active_files
branch
from
d7ffd3f
to
b94ff34
Compare
pdambrauskas
force-pushed
the
add_max_active_files
branch
from
b94ff34
to
f9d6dcf
Compare
|
@HenryCaiHaiying updated. Changed default value to |
|
Looks good to me, thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #785
Keeps active file under
secor.max.file.count(default 100)@HenryCaiHaiying , what do you think, is this the right way to approach this problem? I was thinking, maybe Files should be sorted by size before calling
checkTopicPartitionso that the biggest file is uploaded first, but decided to keep that simple for now.Tried it for our use case (big number of partitions in small amount of time) it helped with OutOfMemory exception.