Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENV variables options #23

Merged
merged 1 commit into from
Sep 8, 2016
Merged

Add ENV variables options #23

merged 1 commit into from
Sep 8, 2016

Conversation

nichochar
Copy link
Collaborator

@nichochar nichochar commented Aug 21, 2016

This is a reproduction of #3 (unfortunately that build is broken because of old, flakey tests, and author is unresponsive.

The idea is still valid though, so I reproduced his work here.

@jparise
Copy link
Collaborator

jparise commented Aug 21, 2016

Perhaps we should just add a single REDIS_URL environmental variable that is passed to Client.from_url?

https://github.com/andymccurdy/redis-py/blob/master/redis/client.py#L454

@nichochar
Copy link
Collaborator Author

We could, but in that case do you suggest changing the way we instantiate redis and use the from_url?

I was just extending our current call to be parametrizable. I can look into calling redis differently.

@jparise
Copy link
Collaborator

jparise commented Aug 22, 2016

Yes, that's my suggestion. That would give us a single way for people to set all of the connection parameters (including username and password).

@nichochar
Copy link
Collaborator Author

I will merge this for now, since it gives more custom ability to tune your connection. But I added a ticket as per your suggestion to use URL and instantiate the client with a different call.

@nichochar nichochar merged commit c22c902 into master Sep 8, 2016
@nichochar nichochar deleted the more-env-vars branch April 24, 2017 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants