Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support python37 #90

Merged
merged 6 commits into from
Jul 16, 2018

Conversation

samueldg
Copy link
Contributor

Add support for Python 3.7

  • Updated all PyPI dependencies (requirements and dev-requirements) to latest stable
  • Added Python 3.7 in tested versions (tox and Travis CI)
  • Updated base Docker image to python:3.7-slim
    • Takes the base image size from 916MB down to 143MB!

⚠️ Currently this will fail because of: travis-ci/travis-ci#9815 ⚠️
Wanted to submit regardless to see if there's interest in merging this eventually.

All PyPI packages now have the latest version available.
Also used the "slim" version, which will drastically reduce the
image size.

Base image sizes comparison:

| python:3.7-slim | 143MB |
| python:3.7      | 916MB |
.travis.yml Outdated
@@ -4,6 +4,7 @@ python:
- "3.4"
- "3.5"
- "3.6"
- "3.7"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just comment this out until the Travis issue is resolved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did that in 867dc24!

@nichochar
Copy link
Collaborator

This is great, thanks @samueldg ! I agree with @jparise we can remove the 3.7 from the travis.yml file for now and put it back once that issue is resolved. If we decide to do that, we should open an issue referencing the travis one to track progress easily and remind our future selves to update the travis config

Currently Travis doesn't support Python 3.7 yet,
but this should be addressed soon:

    travis-ci/travis-ci#9815
@samueldg
Copy link
Contributor Author

@nichochar @jparise Thanks for the quick response 😄

I just commented out the Python 3.7 line in the travis.yml file, and create #91 to track the issue.

@@ -4,6 +4,7 @@ python:
- "3.4"
- "3.5"
- "3.6"
# - "3.7" # TODO: Re-enable after https://github.com/travis-ci/travis-ci/issues/9815 is fixed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@nichochar nichochar merged commit 2b53eed into pinterest:master Jul 16, 2018
@samueldg samueldg deleted the feature/support-python37 branch July 16, 2018 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants