Skip to content
This repository has been archived by the owner on Oct 3, 2018. It is now read-only.

Use optimistic locking to reduce lock contention in metric store #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

deqinw
Copy link
Contributor

@deqinw deqinw commented Oct 27, 2017

Replace intrinsic lock and explicit ReentrantReadWriteLock with Java's implementation of optimistic readers-writer lock to improve throughput.

Remove "throws" clause where no exception is thrown. More specific checked exception type should be declared if there will be exception thrown from those functions in the future.

Avoid naming local variables in VarBitTimeSeries.deserialize() with the same name as class variable. This could cause confusion and nasty bugs.

@deqinw deqinw changed the title Use optimistic locking to reduce lock cnotention in metric store Use optimistic locking to reduce lock contention in metric store Oct 27, 2017
@mansu
Copy link
Contributor

mansu commented Oct 31, 2017

Thanks for the patch. We are stabilizing the code this week and running some tests. So, I will merge this patch next week. If you can separate the locking change from the rest of the code, I will merge the rest of the changes first.

@deqinw
Copy link
Contributor Author

deqinw commented Nov 11, 2017

Sure. Sorry I've been busy these days and didn't pay much attention to my Github account. I'll separate the change and submit PR after I come back from my vacation next week, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants