Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed function to change point tests. #1392

Merged
merged 3 commits into from
Aug 24, 2021
Merged

Renamed function to change point tests. #1392

merged 3 commits into from
Aug 24, 2021

Conversation

MichaelClerx
Copy link
Member

See #1391.

How's this?

@MichaelClerx MichaelClerx requested a review from a team August 17, 2021 11:58
@MichaelClerx
Copy link
Member Author

I'm just doing a quick re-run of the method merge tests, so a quick yes or no on this one would be very helpful 😅😅😅

fcooper8472
fcooper8472 requested changes Aug 24, 2021
View reviewed changes
Copy link
Member

@fcooper8472 fcooper8472 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except we now have a whole bunch of

import pints.cptests as ft

Change to cp or cpt?

@MichaelClerx
Copy link
Member Author

@fcooper8472 Done!

@fcooper8472 fcooper8472 self-requested a review August 24, 2021 12:07
@MichaelClerx MichaelClerx merged commit a602921 into issue-1294-functional-testing-module Aug 24, 2021
@MichaelClerx MichaelClerx deleted the func-test-rename branch August 24, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcooper8472 fcooper8472 fcooper8472 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MichaelClerx @fcooper8472