Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated golangci-lint config #208

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Apr 2, 2024

Executing golangci-lint run using old config generates the following warnings:

WARN [config_reader] The configuration option run.skip-dirs-use-default is deprecated, please use issues.exclude-dirs-use-default.
WARN [config_reader] The configuration option linters.govet.check-shadowing is deprecated. Please enable shadow instead, if you are not using enable-all.

Description

Before
Screenshot 2024-04-01 at 20 59 13

After
Screenshot 2024-04-01 at 21 26 42

Reference issue

No issue open

Executing `golangci-lint run` using old config generates the following
warnings:

WARN [config_reader] The configuration option
    `run.skip-dirs-use-default` is deprecated, please use
    `issues.exclude-dirs-use-default`.
WARN [config_reader] The configuration option
    `linters.govet.check-shadowing` is deprecated. Please enable
    `shadow` instead, if you are not using `enable-all`.
@Sean-Der Sean-Der merged commit 376ba10 into pion:master Apr 2, 2024
3 checks passed
@mogren mogren deleted the remove-golangci-warnings branch April 2, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants