Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle ChannelAck message #81

Closed
Sean-Der opened this issue Sep 21, 2020 · 1 comment · Fixed by #122
Closed

Properly handle ChannelAck message #81

Sean-Der opened this issue Sep 21, 2020 · 1 comment · Fixed by #122

Comments

@Sean-Der
Copy link
Member

Right now we assume the channel is open right away. We actually shouldn't fire the Open event until we get a ChannelAck back.
@chrisprobst
Copy link

chrisprobst commented Sep 24, 2020 •
edited

@Sean-Der Do you think this issue is also related to pion/webrtc#1063 ?

This was referenced Oct 25, 2021
Merged
Merged
Sean-Der pushed a commit to daonb/datachannel that referenced this issue Oct 27, 2021
@daonb @Sean-Der
Handle ChannelAck messages
8ea0d98 
Add a OnChannelOpen handler. This allows us to fire OnOpen messages
correctly in pion/webrtc

Fixes pion#81
Relates to pion/webrtc#1063
Sean-Der pushed a commit to daonb/datachannel that referenced this issue Oct 27, 2021
@daonb @Sean-Der
Handle ChannelAck messages
629ac6a 
Add a OnOpenComplete handler. This allows us to fire OnOpen messages
correctly in pion/webrtc

Fixes pion#81
Relates to pion/webrtc#1063
Sean-Der pushed a commit to daonb/datachannel that referenced this issue Oct 27, 2021
@daonb @Sean-Der
Handle ChannelAck messages
76f0316 
Add a OnOpenComplete handler. This allows us to fire OnOpen messages
correctly in pion/webrtc

Fixes pion#81
Relates to pion/webrtc#1063
Sean-Der pushed a commit to daonb/datachannel that referenced this issue Oct 27, 2021
@daonb @Sean-Der
Handle ChannelAck messages
e992e95 
Add a OnOpenComplete handler. This allows us to fire OnOpen messages
correctly in pion/webrtc

Fixes pion#81
Relates to pion/webrtc#1063
Sean-Der pushed a commit that referenced this issue Oct 27, 2021
@daonb @Sean-Der
Handle ChannelAck messages
b9a54c5 
Add a OnOpenComplete handler. This allows us to fire OnOpen messages
correctly in pion/webrtc

Fixes #81
Relates to pion/webrtc#1063
Sean-Der pushed a commit to daonb/webrtc that referenced this issue Oct 27, 2021
@daonb @Sean-Der
Use OnOpen handler for DataChannels
1d5500b 
Using an improvment of pion/datachannel, the channel opener can now
set an event to be called when the DATA_CHANNEL_ACK message is recieved

Resolves pion#1063
Relates to pion/datachannel#81
Sean-Der pushed a commit to daonb/webrtc that referenced this issue Oct 27, 2021
@daonb @Sean-Der
Use OnOpen handler for DataChannels
b5990e4 
Using an improvment of pion/datachannel, the channel opener can now
set an event to be called when the DATA_CHANNEL_ACK message is recieved

Resolves pion#1063
Relates to pion/datachannel#81
Sean-Der pushed a commit to daonb/webrtc that referenced this issue Oct 28, 2021
@daonb @Sean-Der
Use OnOpen handler for DataChannels
8a69697 
Using an improvment of pion/datachannel, the channel opener can now
set an event to be called when the DATA_CHANNEL_ACK message is recieved

Resolves pion#1063
Relates to pion/datachannel#81
Sean-Der pushed a commit to daonb/webrtc that referenced this issue Oct 28, 2021
@daonb @Sean-Der
Use OnOpen handler for DataChannels
b5ff367 
Using an improvment of pion/datachannel, the channel opener can now
set an event to be called when the DATA_CHANNEL_ACK message is recieved

Resolves pion#1063
Relates to pion/datachannel#81
Sean-Der pushed a commit to daonb/webrtc that referenced this issue Oct 28, 2021
@daonb @Sean-Der
Use OnOpen handler for DataChannels
3ecbb39 
Using an improvment of pion/datachannel, the channel opener can now
set an event to be called when the DATA_CHANNEL_ACK message is recieved

Resolves pion#1063
Relates to pion/datachannel#81
Sean-Der pushed a commit to pion/webrtc that referenced this issue Oct 28, 2021
@daonb @Sean-Der
Use OnOpen handler for DataChannels
0180ee3 
Using an improvment of pion/datachannel, the channel opener can now
set an event to be called when the DATA_CHANNEL_ACK message is recieved

Resolves #1063
Relates to pion/datachannel#81
daonb added a commit to daonb/webrtc that referenced this issue Nov 20, 2022
@daonb
Use OnOpen handler for DataChannels
c5faa92 
Using an improvment of pion/datachannel, the channel opener can now
set an event to be called when the DATA_CHANNEL_ACK message is recieved

Resolves pion#1063
Relates to pion/datachannel#81
daonb added a commit to daonb/webrtc that referenced this issue Nov 22, 2022
@daonb
Use OnOpen handler for DataChannels
5f8f2ad 
Using an improvment of pion/datachannel, the channel opener can now
set an event to be called when the DATA_CHANNEL_ACK message is recieved

Resolves pion#1063
Relates to pion/datachannel#81
daonb added a commit to daonb/webrtc that referenced this issue Jan 30, 2023
@daonb
Use OnOpen handler for DataChannels
1050a6d 
Using an improvment of pion/datachannel, the channel opener can now
set an event to be called when the DATA_CHANNEL_ACK message is recieved

Resolves pion#1063
Relates to pion/datachannel#81
ourwarmhouse added a commit to ourwarmhouse/store-backend-go that referenced this issue May 1, 2024
@ourwarmhouse
Use OnOpen handler for DataChannels
3d447ef 
Using an improvment of pion/datachannel, the channel opener can now
set an event to be called when the DATA_CHANNEL_ACK message is recieved

Resolves #1063
Relates to pion/datachannel#81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding OnOpenComplete daonb/datachannel
2 participants
@chrisprobst @Sean-Der