Add end to end tests using OpenSSL #193

igolaizola · 2020-02-17T14:33:40Z

End to end tests are now executed in the folowing modes:

default: pion client, pion server
openssl_client: openssl client, pion server
openssl_server: pion client, openssl server

OpenSSL is launched using exec.Command

TODO:

Changes to CI to install OpenSSL
Make OpenSSL server work with PSK tests
Make OpenSSL work with ed25519 test

.travis.yml

at-wat

How about doing like this? feature/e2e-openssl...feature/e2e-openssl-at-wat-patch

e2e/e2e_openssl_test.go

e2e/e2e_test.go

igolaizola · 2020-02-18T14:22:33Z

How about doing like this? feature/e2e-openssl...feature/e2e-openssl-at-wat-patch

Thanks for doing the job! I've already merged your changes into this branch.

at-wat

My patch commit is errored due to the commit message lint.
Could you update the commit message?

e2e/e2e_openssl_test.go

.github/workflows/browser-e2e.yaml

daenney · 2020-02-19T10:17:58Z

This is pretty great, thanks so much for working on this!

I'm wondering if we should go ahead and merge this, and then add ED25519 and PSK tests incrementally, or if we want to hold this up until the other two are implemented? If the former, we should probably drop e2e/e2e_openssl_v113_test.go though b/c that's all commented out right now.

igolaizola · 2020-02-20T07:48:58Z

This is pretty great, thanks so much for working on this!

I'm wondering if we should go ahead and merge this, and then add ED25519 and PSK tests incrementally, or if we want to hold this up until the other two are implemented? If the former, we should probably drop e2e/e2e_openssl_v113_test.go though b/c that's all commented out right now.

I agree with merging this even if ED25519 and PSK tests are not implemented. We could update the E2E issue #11 to mark what has been done and what is missing.

Having commented code int e2e/e2e_openssl_v113_test.go makes easier to continue the development and fix those tests... so I am not sure if we should drop it or not.

I am updating TODO(igolaizola) to just TODO to encourage anyone to finish it 😄

at-wat · 2020-02-20T08:25:47Z

Having commented code int e2e/e2e_openssl_v113_test.go makes easier to continue the development and fix those tests... so I am not sure if we should drop it or not.

I feel it's fine to keep it commented for now.
Maybe, it's better to add something like t.Skip("This test is not yet enabled since ......") to indicate the test log that it is not actually executed.

e2e/e2e_openssl_test.go

igolaizola · 2020-02-20T12:11:03Z

Having commented code int e2e/e2e_openssl_v113_test.go makes easier to continue the development and fix those tests... so I am not sure if we should drop it or not.

I feel it's fine to keep it commented for now.
Maybe, it's better to add something like t.Skip("This test is not yet enabled since ......") to indicate the test log that it is not actually executed.

I have uncommented PSK tests and skipped ED25519 tets

e2e/e2e_openssl_test.go

daenney · 2020-02-24T09:52:33Z

Current E2E test output:

2020-02-24T09:43:21.1915948Z === RUN   TestPionE2ELossy
2020-02-24T09:43:21.2019263Z === RUN   TestPionE2ELossy/Loss0_MTU0
2020-02-24T09:43:21.2634590Z === RUN   TestPionE2ELossy/Loss10_MTU0
2020-02-24T09:43:21.3761087Z === RUN   TestPionE2ELossy/Loss20_MTU0
2020-02-24T09:43:21.6923514Z === RUN   TestPionE2ELossy/Loss50_MTU0
2020-02-24T09:43:22.4148723Z === RUN   TestPionE2ELossy/Loss0_MTU0_WithCliAuth
2020-02-24T09:43:22.4763434Z === RUN   TestPionE2ELossy/Loss10_MTU0_WithCliAuth
2020-02-24T09:43:22.6910399Z === RUN   TestPionE2ELossy/Loss20_MTU0_WithCliAuth
2020-02-24T09:43:22.8236299Z === RUN   TestPionE2ELossy/Loss50_MTU0_WithCliAuth
2020-02-24T09:43:24.5448367Z === RUN   TestPionE2ELossy/Loss0_MTU0_WithTLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA
2020-02-24T09:43:24.6062105Z === RUN   TestPionE2ELossy/Loss10_MTU0_WithTLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA
2020-02-24T09:43:24.8301740Z === RUN   TestPionE2ELossy/Loss20_MTU0_WithTLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA
2020-02-24T09:43:24.9422616Z === RUN   TestPionE2ELossy/Loss50_MTU0_WithTLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA
2020-02-24T09:43:25.7673315Z === RUN   TestPionE2ELossy/Loss10_MTU100_WithCliAuth
2020-02-24T09:43:26.2563136Z === RUN   TestPionE2ELossy/Loss20_MTU100_WithCliAuth
2020-02-24T09:43:26.5011353Z === RUN   TestPionE2ELossy/Loss50_MTU100_WithCliAuth
2020-02-24T09:43:28.0682086Z --- PASS: TestPionE2ELossy (6.88s)
2020-02-24T09:43:28.0682659Z     --- PASS: TestPionE2ELossy/Loss0_MTU0 (0.06s)
2020-02-24T09:43:28.0683046Z     --- PASS: TestPionE2ELossy/Loss10_MTU0 (0.11s)
2020-02-24T09:43:28.0683456Z     --- PASS: TestPionE2ELossy/Loss20_MTU0 (0.32s)
2020-02-24T09:43:28.0683865Z     --- PASS: TestPionE2ELossy/Loss50_MTU0 (0.72s)
2020-02-24T09:43:28.0684288Z     --- PASS: TestPionE2ELossy/Loss0_MTU0_WithCliAuth (0.06s)
2020-02-24T09:43:28.0684680Z     --- PASS: TestPionE2ELossy/Loss10_MTU0_WithCliAuth (0.21s)
2020-02-24T09:43:28.0685111Z     --- PASS: TestPionE2ELossy/Loss20_MTU0_WithCliAuth (0.13s)
2020-02-24T09:43:28.0685662Z     --- PASS: TestPionE2ELossy/Loss50_MTU0_WithCliAuth (1.72s)
2020-02-24T09:43:28.0686154Z     --- PASS: TestPionE2ELossy/Loss0_MTU0_WithTLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA (0.06s)
2020-02-24T09:43:28.0686590Z     --- PASS: TestPionE2ELossy/Loss10_MTU0_WithTLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA (0.22s)
2020-02-24T09:43:28.0687082Z     --- PASS: TestPionE2ELossy/Loss20_MTU0_WithTLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA (0.11s)
2020-02-24T09:43:28.0687565Z     --- PASS: TestPionE2ELossy/Loss50_MTU0_WithTLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA (0.82s)
2020-02-24T09:43:28.0688081Z     --- PASS: TestPionE2ELossy/Loss10_MTU100_WithCliAuth (0.49s)
2020-02-24T09:43:28.0688520Z     --- PASS: TestPionE2ELossy/Loss20_MTU100_WithCliAuth (0.24s)
2020-02-24T09:43:28.0688892Z     --- PASS: TestPionE2ELossy/Loss50_MTU100_WithCliAuth (1.57s)
2020-02-24T09:43:28.0689085Z === RUN   TestPionOpenSSLE2ESimple
2020-02-24T09:43:28.0689257Z === RUN   TestPionOpenSSLE2ESimple/OpenSSLServer
2020-02-24T09:43:28.2706496Z === RUN   TestPionOpenSSLE2ESimple/OpenSSLServer/TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
2020-02-24T09:43:29.0365456Z === RUN   TestPionOpenSSLE2ESimple/OpenSSLServer/TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA
2020-02-24T09:43:29.9419007Z === RUN   TestPionOpenSSLE2ESimple/OpenSSLClient
2020-02-24T09:43:30.1443911Z === RUN   TestPionOpenSSLE2ESimple/OpenSSLClient/TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
2020-02-24T09:43:30.1518133Z /tmp/cert.pem026375242 /tmp/key.pem776895777
2020-02-24T09:43:30.1552528Z depth=0 CN = localhost
2020-02-24T09:43:30.1565510Z verify error:num=20:unable to get local issuer certificate
2020-02-24T09:43:30.1565735Z verify return:1
2020-02-24T09:43:30.1565909Z depth=0 CN = localhost
2020-02-24T09:43:30.1566061Z verify error:num=21:unable to verify the first certificate
2020-02-24T09:43:30.1566204Z verify return:1
2020-02-24T09:43:30.3586902Z === RUN   TestPionOpenSSLE2ESimple/OpenSSLClient/TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA
2020-02-24T09:43:30.3593099Z /tmp/cert.pem552431628 /tmp/key.pem785797115
2020-02-24T09:43:30.3644627Z depth=0 CN = localhost
2020-02-24T09:43:30.3645739Z verify error:num=20:unable to get local issuer certificate
2020-02-24T09:43:30.3651973Z verify return:1
2020-02-24T09:43:30.3652159Z depth=0 CN = localhost
2020-02-24T09:43:30.3652298Z verify error:num=21:unable to verify the first certificate
2020-02-24T09:43:30.3652391Z verify return:1
2020-02-24T09:43:30.7679729Z --- PASS: TestPionOpenSSLE2ESimple (2.70s)
2020-02-24T09:43:30.7680645Z     --- PASS: TestPionOpenSSLE2ESimple/OpenSSLServer (1.87s)
2020-02-24T09:43:30.7681384Z         --- PASS: TestPionOpenSSLE2ESimple/OpenSSLServer/TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 (0.77s)
2020-02-24T09:43:30.7682119Z         --- PASS: TestPionOpenSSLE2ESimple/OpenSSLServer/TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA (0.70s)
2020-02-24T09:43:30.7682738Z     --- PASS: TestPionOpenSSLE2ESimple/OpenSSLClient (0.83s)
2020-02-24T09:43:30.7683365Z         --- PASS: TestPionOpenSSLE2ESimple/OpenSSLClient/TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 (0.21s)
2020-02-24T09:43:30.7684203Z         --- PASS: TestPionOpenSSLE2ESimple/OpenSSLClient/TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA (0.21s)
2020-02-24T09:43:30.7684485Z === RUN   TestPionOpenSSLE2ESimplePSK
2020-02-24T09:43:30.7684767Z === RUN   TestPionOpenSSLE2ESimplePSK/OpenSSLServer
2020-02-24T09:43:30.9698105Z === RUN   TestPionOpenSSLE2ESimplePSK/OpenSSLServer/TLS_PSK_WITH_AES_128_CCM
2020-02-24T09:43:31.6719974Z === RUN   TestPionOpenSSLE2ESimplePSK/OpenSSLServer/TLS_PSK_WITH_AES_128_CCM_8
2020-02-24T09:43:32.3742314Z === RUN   TestPionOpenSSLE2ESimplePSK/OpenSSLServer/TLS_PSK_WITH_AES_128_GCM_SHA256
2020-02-24T09:43:33.2776226Z === RUN   TestPionOpenSSLE2ESimplePSK/OpenSSLClient
2020-02-24T09:43:33.4786548Z === RUN   TestPionOpenSSLE2ESimplePSK/OpenSSLClient/TLS_PSK_WITH_AES_128_CCM
2020-02-24T09:43:33.6991486Z === RUN   TestPionOpenSSLE2ESimplePSK/OpenSSLClient/TLS_PSK_WITH_AES_128_CCM_8
2020-02-24T09:43:33.9176658Z === RUN   TestPionOpenSSLE2ESimplePSK/OpenSSLClient/TLS_PSK_WITH_AES_128_GCM_SHA256
2020-02-24T09:43:34.3375886Z --- PASS: TestPionOpenSSLE2ESimplePSK (3.57s)
2020-02-24T09:43:34.3376505Z     --- PASS: TestPionOpenSSLE2ESimplePSK/OpenSSLServer (2.51s)
2020-02-24T09:43:34.3377191Z         --- PASS: TestPionOpenSSLE2ESimplePSK/OpenSSLServer/TLS_PSK_WITH_AES_128_CCM (0.70s)
2020-02-24T09:43:34.3377982Z         --- PASS: TestPionOpenSSLE2ESimplePSK/OpenSSLServer/TLS_PSK_WITH_AES_128_CCM_8 (0.70s)
2020-02-24T09:43:34.3378680Z         --- PASS: TestPionOpenSSLE2ESimplePSK/OpenSSLServer/TLS_PSK_WITH_AES_128_GCM_SHA256 (0.70s)
2020-02-24T09:43:34.3379268Z     --- PASS: TestPionOpenSSLE2ESimplePSK/OpenSSLClient (1.06s)
2020-02-24T09:43:34.3380117Z         --- PASS: TestPionOpenSSLE2ESimplePSK/OpenSSLClient/TLS_PSK_WITH_AES_128_CCM (0.22s)
2020-02-24T09:43:34.3380813Z         --- PASS: TestPionOpenSSLE2ESimplePSK/OpenSSLClient/TLS_PSK_WITH_AES_128_CCM_8 (0.22s)
2020-02-24T09:43:34.3381561Z         --- PASS: TestPionOpenSSLE2ESimplePSK/OpenSSLClient/TLS_PSK_WITH_AES_128_GCM_SHA256 (0.22s)
2020-02-24T09:43:34.3381828Z === RUN   TestPionOpenSSLE2EMTUs
2020-02-24T09:43:34.3381997Z === RUN   TestPionOpenSSLE2EMTUs/OpenSSLServer
2020-02-24T09:43:34.5389999Z === RUN   TestPionOpenSSLE2EMTUs/OpenSSLServer/MTU10000
2020-02-24T09:43:35.2433201Z === RUN   TestPionOpenSSLE2EMTUs/OpenSSLServer/MTU1000
2020-02-24T09:43:35.9487615Z === RUN   TestPionOpenSSLE2EMTUs/OpenSSLServer/MTU100
2020-02-24T09:43:36.8523709Z === RUN   TestPionOpenSSLE2EMTUs/OpenSSLClient
2020-02-24T09:43:37.0544630Z === RUN   TestPionOpenSSLE2EMTUs/OpenSSLClient/MTU10000
2020-02-24T09:43:37.0550828Z /tmp/cert.pem580863796 /tmp/key.pem135136003
2020-02-24T09:43:37.0606374Z depth=0 CN = localhost
2020-02-24T09:43:37.0606590Z verify error:num=20:unable to get local issuer certificate
2020-02-24T09:43:37.0606745Z verify return:1
2020-02-24T09:43:37.0606832Z depth=0 CN = localhost
2020-02-24T09:43:37.0607132Z verify error:num=21:unable to verify the first certificate
2020-02-24T09:43:37.0607298Z verify return:1
2020-02-24T09:43:37.2627160Z === RUN   TestPionOpenSSLE2EMTUs/OpenSSLClient/MTU1000
2020-02-24T09:43:37.2627582Z /tmp/cert.pem076572294 /tmp/key.pem105133613
2020-02-24T09:43:37.2694578Z depth=0 CN = localhost
2020-02-24T09:43:37.2695837Z verify error:num=20:unable to get local issuer certificate
2020-02-24T09:43:37.2695999Z verify return:1
2020-02-24T09:43:37.2696141Z depth=0 CN = localhost
2020-02-24T09:43:37.2696309Z verify error:num=21:unable to verify the first certificate
2020-02-24T09:43:37.2696404Z verify return:1
2020-02-24T09:43:37.4711982Z === RUN   TestPionOpenSSLE2EMTUs/OpenSSLClient/MTU100
2020-02-24T09:43:37.4723864Z /tmp/cert.pem307142056 /tmp/key.pem342056167
2020-02-24T09:43:37.4800516Z depth=0 CN = localhost
2020-02-24T09:43:37.4801082Z verify error:num=20:unable to get local issuer certificate
2020-02-24T09:43:37.4806798Z verify return:1
2020-02-24T09:43:37.4806916Z depth=0 CN = localhost
2020-02-24T09:43:37.4807053Z verify error:num=21:unable to verify the first certificate
2020-02-24T09:43:37.4807193Z verify return:1
2020-02-24T09:43:37.8826839Z --- PASS: TestPionOpenSSLE2EMTUs (3.55s)
2020-02-24T09:43:37.8827717Z     --- PASS: TestPionOpenSSLE2EMTUs/OpenSSLServer (2.51s)
2020-02-24T09:43:37.8828367Z         --- PASS: TestPionOpenSSLE2EMTUs/OpenSSLServer/MTU10000 (0.70s)
2020-02-24T09:43:37.8829001Z         --- PASS: TestPionOpenSSLE2EMTUs/OpenSSLServer/MTU1000 (0.70s)
2020-02-24T09:43:37.8829871Z         --- PASS: TestPionOpenSSLE2EMTUs/OpenSSLServer/MTU100 (0.70s)
2020-02-24T09:43:37.8830492Z     --- PASS: TestPionOpenSSLE2EMTUs/OpenSSLClient (1.03s)
2020-02-24T09:43:37.8831283Z         --- PASS: TestPionOpenSSLE2EMTUs/OpenSSLClient/MTU10000 (0.21s)
2020-02-24T09:43:37.8831913Z         --- PASS: TestPionOpenSSLE2EMTUs/OpenSSLClient/MTU1000 (0.21s)
2020-02-24T09:43:37.8832447Z         --- PASS: TestPionOpenSSLE2EMTUs/OpenSSLClient/MTU100 (0.21s)
2020-02-24T09:43:37.8832770Z === RUN   TestPionOpenSSLE2ESimpleED25519
2020-02-24T09:43:37.8833346Z --- SKIP: TestPionOpenSSLE2ESimpleED25519 (0.00s)
2020-02-24T09:43:37.8833615Z     e2e_openssl_v113_test.go:10: TODO: make ED25519 test work with openssl
2020-02-24T09:43:37.8833796Z === RUN   TestPionE2ESimple
2020-02-24T09:43:38.0953149Z === RUN   TestPionE2ESimple/TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
2020-02-24T09:43:39.1530092Z === RUN   TestPionE2ESimple/TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA
2020-02-24T09:43:39.1532338Z --- PASS: TestPionE2ESimple (0.81s)
2020-02-24T09:43:39.1533944Z     --- PASS: TestPionE2ESimple/TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 (0.20s)
2020-02-24T09:43:39.1535603Z     --- PASS: TestPionE2ESimple/TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA (0.20s)
2020-02-24T09:43:39.1535902Z === RUN   TestPionE2ESimplePSK
2020-02-24T09:43:39.1536088Z === RUN   TestPionE2ESimplePSK/TLS_PSK_WITH_AES_128_CCM
2020-02-24T09:43:39.1536261Z === RUN   TestPionE2ESimplePSK/TLS_PSK_WITH_AES_128_CCM_8
2020-02-24T09:43:39.2929265Z === RUN   TestPionE2ESimplePSK/TLS_PSK_WITH_AES_128_GCM_SHA256
2020-02-24T09:43:39.6962746Z --- PASS: TestPionE2ESimplePSK (1.01s)
2020-02-24T09:43:39.6963530Z     --- PASS: TestPionE2ESimplePSK/TLS_PSK_WITH_AES_128_CCM (0.20s)
2020-02-24T09:43:39.6964111Z     --- PASS: TestPionE2ESimplePSK/TLS_PSK_WITH_AES_128_CCM_8 (0.20s)
2020-02-24T09:43:39.6964680Z     --- PASS: TestPionE2ESimplePSK/TLS_PSK_WITH_AES_128_GCM_SHA256 (0.20s)
2020-02-24T09:43:39.6964893Z === RUN   TestPionE2EMTUs
2020-02-24T09:43:39.8974451Z === RUN   TestPionE2EMTUs/MTU10000
2020-02-24T09:43:40.1005205Z === RUN   TestPionE2EMTUs/MTU1000
2020-02-24T09:43:40.3030033Z === RUN   TestPionE2EMTUs/MTU100
2020-02-24T09:43:40.7070849Z --- PASS: TestPionE2EMTUs (1.01s)
2020-02-24T09:43:40.7071471Z     --- PASS: TestPionE2EMTUs/MTU10000 (0.20s)
2020-02-24T09:43:40.7071755Z     --- PASS: TestPionE2EMTUs/MTU1000 (0.20s)
2020-02-24T09:43:40.7072019Z     --- PASS: TestPionE2EMTUs/MTU100 (0.20s)
2020-02-24T09:43:40.7072120Z === RUN   TestPionE2ESimpleED25519
2020-02-24T09:43:40.9088623Z === RUN   TestPionE2ESimpleED25519/TLS_ECDHE_ECDSA_WITH_AES_128_CCM
2020-02-24T09:43:41.1127920Z === RUN   TestPionE2ESimpleED25519/TLS_ECDHE_ECDSA_WITH_AES_128_CCM_8
2020-02-24T09:43:41.3160063Z === RUN   TestPionE2ESimpleED25519/TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
2020-02-24T09:43:41.5185320Z === RUN   TestPionE2ESimpleED25519/TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA
2020-02-24T09:43:41.9220642Z --- PASS: TestPionE2ESimpleED25519 (1.21s)
2020-02-24T09:43:41.9222038Z     --- PASS: TestPionE2ESimpleED25519/TLS_ECDHE_ECDSA_WITH_AES_128_CCM (0.20s)
2020-02-24T09:43:41.9223071Z     --- PASS: TestPionE2ESimpleED25519/TLS_ECDHE_ECDSA_WITH_AES_128_CCM_8 (0.20s)
2020-02-24T09:43:41.9224105Z     --- PASS: TestPionE2ESimpleED25519/TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 (0.20s)
2020-02-24T09:43:41.9225093Z     --- PASS: TestPionE2ESimpleED25519/TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA (0.20s)
2020-02-24T09:43:41.9225633Z PASS
2020-02-24T09:43:41.9242446Z ok  	github.com/pion/dtls/v2/e2e	20.742s

We're getting there! Need to figure out if we care about that OpenSSL error though and if not how to silence it.

igolaizola · 2020-02-24T11:54:41Z

Once #203 is merged OpenSSL errors should disappear.

We could also add this, to force any future verification error make the test fail:

-verify_return_error       Close connection on verification error

daenney · 2020-02-24T13:05:37Z

I like verify_return_error, that's a good safety net for tests. I've OKed #203 so if you want to merge that and then rebase we should be all good.

igolaizola · 2020-02-24T14:11:43Z

This now looks pretty good!

@daenney @at-wat Are you ok with having a few commits? or should I squash them?

daenney · 2020-02-24T14:33:40Z

I'd prefer a squash, since it's essentially a single "feature". ~~But you can just use the squash merge option for that in GitHub, no need to squash and push yourself.~~ I'm wrong, that's not enable don this repo.

cc @Sean-Der could we allow for that ^^? Avoids an extra back-and-forth and re-approving the same thing.

End to end tests are now executed in the folowing modes: - pion client + pion server - openssl client + pion server - pion client + openssl server OpenSSL is launched using `exec.Command` and therefore `openssl` command must be available before running these tests. Tests are enabled via `openssl` tag.

at-wat

LGTM!

igolaizola requested review from at-wat, daenney and Sean-Der February 17, 2020 14:35

daenney reviewed Feb 17, 2020

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

igolaizola force-pushed the feature/e2e-openssl branch 2 times, most recently from 4299695 to 10db9a6 Compare February 17, 2020 15:53

at-wat reviewed Feb 18, 2020

View reviewed changes

e2e/e2e_openssl_test.go Outdated Show resolved Hide resolved

e2e/e2e_test.go Outdated Show resolved Hide resolved

igolaizola force-pushed the feature/e2e-openssl branch from 10db9a6 to c734c03 Compare February 18, 2020 14:19

at-wat reviewed Feb 18, 2020

View reviewed changes

e2e/e2e_openssl_test.go Outdated Show resolved Hide resolved

e2e/e2e_openssl_test.go Outdated Show resolved Hide resolved

.github/workflows/browser-e2e.yaml Outdated Show resolved Hide resolved

igolaizola force-pushed the feature/e2e-openssl branch from c734c03 to ae365f2 Compare February 19, 2020 09:13

igolaizola force-pushed the feature/e2e-openssl branch from ae365f2 to 2f9d75c Compare February 20, 2020 07:56

at-wat reviewed Feb 20, 2020

View reviewed changes

e2e/e2e_openssl_test.go Outdated Show resolved Hide resolved

igolaizola force-pushed the feature/e2e-openssl branch from 3982a71 to 079f109 Compare February 21, 2020 07:23

at-wat reviewed Feb 24, 2020

View reviewed changes

e2e/e2e_openssl_test.go Show resolved Hide resolved

igolaizola force-pushed the feature/e2e-openssl branch from 079f109 to ce88a01 Compare February 24, 2020 09:42

igolaizola mentioned this pull request Feb 24, 2020

Add key usage cert-sign to selfsigned certs #203

Merged

igolaizola force-pushed the feature/e2e-openssl branch 2 times, most recently from 3522807 to 19a7e52 Compare February 24, 2020 11:46

igolaizola force-pushed the feature/e2e-openssl branch from 2279cf7 to 1b1f654 Compare February 24, 2020 13:42

daenney approved these changes Feb 24, 2020

View reviewed changes

igolaizola force-pushed the feature/e2e-openssl branch from 1b1f654 to 152c01e Compare February 24, 2020 15:27

at-wat approved these changes Feb 24, 2020

View reviewed changes

igolaizola merged commit e950e1f into master Feb 24, 2020

igolaizola deleted the feature/e2e-openssl branch February 24, 2020 19:58

igolaizola mentioned this pull request Feb 24, 2020

Add E2E tests with OpenSSL #11

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add end to end tests using OpenSSL #193

Add end to end tests using OpenSSL #193

igolaizola commented Feb 17, 2020 •

edited

Loading

at-wat left a comment

igolaizola commented Feb 18, 2020

at-wat left a comment

daenney commented Feb 19, 2020

igolaizola commented Feb 20, 2020

at-wat commented Feb 20, 2020

igolaizola commented Feb 20, 2020

daenney commented Feb 24, 2020

igolaizola commented Feb 24, 2020

daenney commented Feb 24, 2020

igolaizola commented Feb 24, 2020

daenney commented Feb 24, 2020 •

edited

Loading

at-wat left a comment

Add end to end tests using OpenSSL #193

Add end to end tests using OpenSSL #193

Conversation

igolaizola commented Feb 17, 2020 • edited Loading

at-wat left a comment

Choose a reason for hiding this comment

igolaizola commented Feb 18, 2020

at-wat left a comment

Choose a reason for hiding this comment

daenney commented Feb 19, 2020

igolaizola commented Feb 20, 2020

at-wat commented Feb 20, 2020

igolaizola commented Feb 20, 2020

daenney commented Feb 24, 2020

igolaizola commented Feb 24, 2020

daenney commented Feb 24, 2020

igolaizola commented Feb 24, 2020

daenney commented Feb 24, 2020 • edited Loading

at-wat left a comment

Choose a reason for hiding this comment

igolaizola commented Feb 17, 2020 •

edited

Loading

daenney commented Feb 24, 2020 •

edited

Loading