Implement TURN #47
Comments
|
#42 may already solve the 3rd point |
This change will allow us to have custom logic and members per interface type. Relay candidates will have a completely different read loop, and candidate specific state. Relates to #47
This change will allow us to have custom logic and members per interface type. Relay candidates will have a completely different read loop, and candidate specific state. Relates to #47
This implementation is not fully tested, and we don't handle all error case yet. We will continue to work on it though. Tests for send/recv and shutdown are in the works. Relates to #47
|
@hugoArregui I am going to work on getting TURN/STUN tested in travis-ci. This is probably going to take me 2-3 days. Would you be up for getting your checklist stuff re-merged? Sorry for all the breakage, I would love to work together closely and get both your changes in. |
|
@enobufs Any other next steps you can think of? I feel pretty good about where we are at TURN wise! |
|
@Sean-Der @ernado @hugoArregui MANY Thanks to all of you for making this happen in such a short time!! I am sure many pion users will be very happy about the TURN support! I will be updating my app and test the new feature. My time this week is very limited because I have to move into my new apartment this weekend tho, I should be able to get some feedback in the week of June 2) I guess the next step is to further improve ICE including @hugoArregui was planning to do (checklist stuff). Now we have relay candidate, a proper priority control in candidate nomination (and quality assurance) would be desired. Now we have another expert @ernado - awesome! I'm very hopeful that pion would yield very competitive connectivity over other webrtc libraries! |
|
@Sean-Der sure! Let's ensure we are on the same page regarding the implementation though, the thing about the heuristic I wrote in the PR is now we have trickle.. so I'm not sure if it holds.. maybe I can add a "mininumCheckWait" (sorry, awful name) to wait a bit for candidates? |
Using pion/turn add tests for both candidates types Resolves #47
Using pion/turn add tests for both candidates types Resolves #47
Using pion/turn add tests for both candidates types Resolves #47
This is a covering ticket for all the things we need to do.
pion/webrtcpion/webrtctopion/iceICETransportPolicyso we can force TURNpion/icepion/turnctravis-ci, implement a version and confirm it can't regressThe text was updated successfully, but these errors were encountered: