Check if conn is closed before writing to it.

[m1k1o]

Description

Check if connection is closed before writing anything to it.

Reference issue

Fixes #503

[codecov]

Codecov Report

Base: 78.06% // Head: 78.35% // Increases project coverage by +0.29% 🎉

Coverage data is based on head (f3839d7) compared to base (3fe1ae7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   78.06%   78.35%   +0.29%     
==========================================
  Files          36       36              
  Lines        4262     4265       +3     
==========================================
+ Hits         3327     3342      +15     
+ Misses        728      717      -11     
+ Partials      207      206       -1     

Flag	Coverage Δ
go	78.35% <100.00%> (+0.29%)	⬆️
wasm	25.04% <100.00%> (+0.59%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
candidate_base.go	87.83% <100.00%> (+0.10%)	⬆️
tcp_packet_conn.go	76.02% <0.00%> (+6.12%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ashellunts]

Hi @m1k1o, is it possible to write a test for the fix?

[m1k1o]

Simplified by checking the error we receive. Reason for errors not being logged I found in this commit to be Downstream isn't able to distinguish a temporary from a Permanent error yet. But io.ErrClosedPipe is permanent error, therefore it should be returned.

[ashellunts]

👍

[stv0g]

Looks good to me :) Just the commit message CI check is failing :(

[stv0g]

@m1k1o Do you mind fixing the CI commit message check which fails?

Or, are you okay if I do so for you?

[m1k1o]

I can do it later today. But feel free to do it now if you want.

[stv0g]

@m1k1o I adjusted the commit messages. However, it seems like I am lacking the permissions to push the changes to your branch. :(

[m1k1o]

@stv0g i added permissions, can you try again?