JitterBuffer: Fix queue not properly decrementing packet count in some instances #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatsnotright
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #249 +/- ##
==========================================
+ Coverage 72.08% 72.22% +0.14%
==========================================
Files 77 77
Lines 3582 3586 +4
==========================================
+ Hits 2582 2590 +8
+ Misses 866 862 -4
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thatsnotright
force-pushed
the
rob/pq_248_fix
branch
2 times, most recently
from
7a6b1a3
to
a0fd6cd
Compare
In some cases the Priority Queue would not properly decrement packet count even though it did remove a packet from the queue.
thatsnotright
force-pushed
the
rob/pq_248_fix
branch
from
a0fd6cd
to
d29bd2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a few issues with the priority queue not decrementing its count and adds some more test coverage.
Reference issue
Fixes #248