Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on Windows #118

Closed
eberkund opened this issue Jun 5, 2022 · 11 comments · Fixed by #184
Closed

Does not work on Windows #118

eberkund opened this issue Jun 5, 2022 · 11 comments · Fixed by #184

Comments

@eberkund
Copy link

eberkund commented Jun 5, 2022

What happened?

I am using Windows (11) and running the example programs does not work. I start the server and run dns-sd -q my-domain.local from another computer (macOS) and expect to receive a response from the Windows machine running the pion mDNS server. But I don't get anything. I see the mDNS packets coming through in Wireshark but the Go program does not seem to get them and therefore does not respond.

@bendahl
Copy link
Member

bendahl commented Nov 16, 2022

Hi @eberkund,

are you still experiencing this issue? If so, have you tried doing this the other way around? I'm asking, because I'd like to understand whether this is solely a Windows issue or whether something else in your setup might be causing these issues. If it is solely a Windows issue, it might be worth double checking the interface bindings of the server. To my knowledge, the pion/mdns server tries to bind to all available network interfaces - see:

mdns/conn.go

Lines 60 to 65 in 04d95eb

joinErrCount := 0
for i := range ifaces {
if err = conn.JoinGroup(&ifaces[i], &net.UDPAddr{IP: net.IPv4(224, 0, 0, 251)}); err != nil {
joinErrCount++
}
}

I currently cannot test on Windows, so I cannot confirm this. However, using two Linux machines works.

Let me know how it goes.

Cheers
Ben

@Sean-Der: Maybe this is related to #93?

@edaniels
Copy link
Member

edaniels commented May 2, 2023

I think this was fixed in bde59ba

@eberkund
Copy link
Author

eberkund commented May 2, 2023

I think this was fixed in bde59ba

I'll give it a try. Thanks.

@eberkund
Copy link
Author

eberkund commented May 3, 2023

@edaniels, the latest version fixes it. Thanks.

@eberkund eberkund closed this as completed May 3, 2023
@edaniels
Copy link
Member

edaniels commented May 3, 2023

Great! Thanks for testing :)

@eberkund eberkund reopened this Mar 31, 2024
@eberkund
Copy link
Author

@edaniels I am seeing a regression after updating to v2

@edaniels
Copy link
Member

Ah, sorry! Can you describe the regression so I can look into it? We need windows testing

@eberkund
Copy link
Author

eberkund commented Apr 1, 2024

Ah, sorry! Can you describe the regression so I can look into it? We need windows testing

I did a basic investigation with WireShark and the client seems to be working fine. I can see the mDNS queries but the server does not respond back.

Reverting back to 1.x fixed the issue.

@edaniels
Copy link
Member

edaniels commented Apr 1, 2024

Gotcha, I likely broke something, sorry! I'll try to test this in the coming days.

@edaniels
Copy link
Member

edaniels commented Apr 2, 2024

Annoying that it auto closed. @eberkund can you check on v2.0.7?

@eberkund
Copy link
Author

eberkund commented Apr 2, 2024

It works on 2.0.7, thanks!

@eberkund eberkund closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants