Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ifcIndex usage in Windows #184

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Fix ifcIndex usage in Windows #184

merged 1 commit into from
Apr 2, 2024

Conversation

edaniels
Copy link
Member

@edaniels edaniels commented Apr 2, 2024

We were not doing the ifcIndex check correctly which is a bug everywhere but only shows on Windows right now due to not seeing Control Messages.

Fixes #118

We were not doing the ifcIndex check correctly which is a bug
everywhere but only shows on Windows right now due to not seeing
Control Messages.
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 65.75%. Comparing base (1f6facc) to head (a4cb377).

Files Patch % Lines
conn.go 41.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   66.54%   65.75%   -0.80%     
==========================================
  Files           1        1              
  Lines         837      838       +1     
==========================================
- Hits          557      551       -6     
- Misses        204      209       +5     
- Partials       76       78       +2     
Flag Coverage Δ
go 65.75% <41.66%> (-0.80%) ⬇️
wasm 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels edaniels merged commit 689cdb9 into pion:master Apr 2, 2024
13 of 14 checks passed
@edaniels edaniels deleted the winifc branch April 2, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work on Windows
1 participant