-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback codecs #108
Fallback codecs #108
Conversation
Add a wrapper function to initialize codec and try next fallback codec if one fails.
I feel like we need to redesign the codec package. This change definitely works. But, it feels that there's a disconnection between the library and the users.
I think we should instead let the users build the codecs by themselves, and we'll simply take them in |
I'm not very sure what you suggested. |
Sorry, it was definitely very vague. But, yes, you're right. I was thinking that we should remove I think it's really hard to get my idea across with just plain English ^^. So, I've created an experiment here, f6905fe. It's definitely not a working example since I didn't implement everything, but I made changes that I think it's enough to express my idea. Following are the main changes:
|
OK. f6905fe definitely makes sense to me. |
Add a wrapper function to initialize codec and try next fallback codec if one fails.
Reference issue
Fixes #107