allow to close the avfoundation device multiple time #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
=======================================
Coverage 47.23% 47.23%
=======================================
Files 67 67
Lines 4456 4456
=======================================
Hits 2105 2105
Misses 2226 2226
Partials 125 125 Continue to review full report at Codecov.
|
EmrysMyrddin
force-pushed
the
fix/avfoundation_multiple_close
branch
from
2780282
to
0c161f6
Compare
at-wat
reviewed
Jul 31, 2022
at-wat
approved these changes
Aug 1, 2022
Co-authored-by: Atsushi Watanabe <atsushi.w@ieee.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to close multiple time an avfoundation. For now, when closing an alreacy closed VideoTrack comming from avfoundation leads to a panic (close of closed channel)