Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing EnablePictureID in VP8Payloader #453

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vpalmisano
Copy link

The EnablePictureID param is required to create the extended RTP VP8 header. Without this header the VP8 streams cannot be read by the Mediasoup SFU.

Description

Reference issue

The EnablePictureID param is required to create the extended RTP VP8 header. Without this header the VP8 streams cannot be Mediasoup SFU.
Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to be configurable, but seems difficult on the current API.
I think having a global switch like

var VP8EnablePictureID = true

would be good for now.
Enabled by default should be fine.

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 58.15% // Head: 58.15% // No change to project coverage 👍

Coverage data is based on head (f1704d1) compared to base (09f3bcc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #453   +/-   ##
=======================================
  Coverage   58.15%   58.15%           
=======================================
  Files          62       62           
  Lines        3680     3680           
=======================================
  Hits         2140     2140           
  Misses       1413     1413           
  Partials      127      127           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants