Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cLen in nocgo implementation of i444Toi420 #486

Merged
merged 5 commits into from
Apr 15, 2023

Conversation

neversi
Copy link
Contributor

@neversi neversi commented Mar 31, 2023

Description

Fix the length of buffer - cLen in i444toI420() in nocgo implementation

@neversi
Copy link
Contributor Author

neversi commented Mar 31, 2023

While optimizing copy of buffers in nocgo implementation, I have faced with this bug.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (30badd8) 58.83% compared to head (08b53df) 58.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
+ Coverage   58.83%   58.85%   +0.02%     
==========================================
  Files          62       62              
  Lines        3741     3753      +12     
==========================================
+ Hits         2201     2209       +8     
- Misses       1413     1416       +3     
- Partials      127      128       +1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@neversi neversi changed the title Draft: fix cLen in nocgo implementation of i444Toi420 fix cLen in nocgo implementation of i444Toi420 Apr 7, 2023
@neversi
Copy link
Contributor Author

neversi commented Apr 7, 2023

@edaniels could you please at this bug?

@edaniels
Copy link
Member

edaniels commented Apr 9, 2023

Hi @neversi, can you write a test for this? Thanks!

@neversi
Copy link
Contributor Author

neversi commented Apr 15, 2023

@edaniels it can be reproduced by tests with CGO_ENABLED=0

Also, I have added mock scaler to be able to pass tests for nocgo implementation and fix the ratio for i422 converter.

Now all tests pass without errors

Copy link
Member

@edaniels edaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edaniels edaniels merged commit bf290b0 into pion:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants