-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cLen in nocgo implementation of i444Toi420 #486
fix cLen in nocgo implementation of i444Toi420 #486
Conversation
While optimizing copy of buffers in nocgo implementation, I have faced with this bug. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #486 +/- ##
==========================================
+ Coverage 58.83% 58.85% +0.02%
==========================================
Files 62 62
Lines 3741 3753 +12
==========================================
+ Hits 2201 2209 +8
- Misses 1413 1416 +3
- Partials 127 128 +1 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@edaniels could you please at this bug? |
Hi @neversi, can you write a test for this? Thanks! |
…i/mediadevices into fix/convert_nocgo-stride-len-i444
@edaniels it can be reproduced by tests with CGO_ENABLED=0 Also, I have added mock scaler to be able to pass tests for nocgo implementation and fix the ratio for i422 converter. Now all tests pass without errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fix the length of buffer - cLen in
i444toI420()
in nocgo implementation