go mod tidy #533
Merged
go mod tidy #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
|
@at-wat do you think it'd be worthwhile to require passing tests for PRs as a precaution? I don't have strong opinions either way, so just a thought. |
at-wat
approved these changes
Oct 17, 2023
|
@bazile-clyde the branch protection setting already requires passing tests, and the PR of the broken master commit passed the all tests: https://github.com/pion/mediadevices/actions/runs/6388497827 |
|
We can add a workflow that makes a PR to apply go mod tidy automatically |
Ah, I see! Very strange. Nevermind then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The master branch is broken, but it seems simple to fix.
go mod tidyshould do the trick.Reference issue
https://github.com/pion/mediadevices/actions/runs/6471054300/job/17568631995#step:5:11