Correct out of range checking

pion · Aug 9, 2023 · 53779ad · 53779ad
1 parent 4160a9f
commit 53779ad
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/transport_layer_cc.go b/transport_layer_cc.go
@@ -523,17 +523,20 @@ func (t *TransportLayerCC) Unmarshal(rawPacket []byte) error { //nolint:gocognit
 
 	recvDeltasPos := packetStatusPos
 	for _, delta := range t.RecvDeltas {
-		if recvDeltasPos >= totalLength {
-			return errPacketTooShort
-		}
 		if delta.Type == TypeTCCPacketReceivedSmallDelta {
+			if recvDeltasPos+1 > totalLength {
+				return errPacketTooShort
+			}
 			err := delta.Unmarshal(rawPacket[recvDeltasPos : recvDeltasPos+1])
 			if err != nil {
 				return err
 			}
 			recvDeltasPos++
 		}
 		if delta.Type == TypeTCCPacketReceivedLargeDelta {
+			if recvDeltasPos+2 > totalLength {
+				return errPacketTooShort
+			}
 			err := delta.Unmarshal(rawPacket[recvDeltasPos : recvDeltasPos+2])
 			if err != nil {
 				return err