Removing String() method from Packet interface
#108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussion on Slack, this patch undoes the addition of a `String()` method on a Packet. Compound packets now use the new `stringify()` function if a contained Packet doesn't include a `String()` method.
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
==========================================
- Coverage 72.67% 72.45% -0.23%
==========================================
Files 20 20
Lines 1281 1285 +4
==========================================
Hits 931 931
- Misses 264 268 +4
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sean-Der
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per discussion on Slack, this patch undoes the addition
of a
String()method on a Packet. Compound packetsnow use the new
stringify()function if a containedPacket doesn't include a
String()method.