fix empty twcc packet unmarshalling #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 72.45% 72.45%
=======================================
Files 20 20
Lines 1285 1285
=======================================
Hits 931 931
Misses 268 268
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Currently empty twcc packets fail unmarshalling because they are too short. These packets aren't actually invalid, however.
|
🔥 nice, thanks @kevmo314 |
Sean-Der
approved these changes
Nov 19, 2021
|
@kevmo314 want me to tag rtcp and other repos? You have the perms if you want too yourself! |
I can do it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a test case for empty TWCC packets.