Implement RFC 8888 Congestion Control Feedback #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pionbot
force-pushed
the
feat/rfc-8888
branch
from
38e6c68
to
e75ecca
Compare
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
- Coverage 76.56% 76.28% -0.28%
==========================================
Files 20 21 +1
Lines 2227 2353 +126
==========================================
+ Hits 1705 1795 +90
- Misses 435 461 +26
- Partials 87 97 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Some of the best Go code I have read in a while :) LGTM! |
Sean-Der
approved these changes
Feb 1, 2022
Sean-Der
reviewed
Feb 1, 2022
Sean-Der
reviewed
Feb 1, 2022
Sean-Der
reviewed
Feb 1, 2022
Sean-Der
reviewed
Feb 2, 2022
| for i := uint16(0); i < numReports; i++ { | ||
| var mb CCFeedbackMetricBlock | ||
| offset := reportsOffset + 2*i | ||
| if err := mb.unmarshal(rawPacket[offset : offset+2]); err != nil { |
There was a problem hiding this comment.
It wasn't, thanks! I added another check.
mengelbart
force-pushed
the
feat/rfc-8888
branch
from
443648c
to
35d9cc1
Compare
Implements Congestion Control Feedback Reports as defined in https://www.rfc-editor.org/rfc/rfc8888.html
mengelbart
force-pushed
the
feat/rfc-8888
branch
from
35d9cc1
to
680c5bf
Compare
|
Nice! Excited to use this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Congestion Control Feedback Reports as defined in RFC 8888.