Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rtcp-fb:* (Chrome PSA) #152

Merged
merged 1 commit into from
Mar 29, 2024

Commits on Mar 29, 2024

  1. Add support for rtcp-fb:*

    According to Chrome PSA:
    https://groups.google.com/g/discuss-webrtc/c/Y_h2B-NOzW0 rtcp-fb:*
    might start getting sent by chrome in M112. This was rolled back but may
    land again in M114 according to maintainers.
    
    Also, according to
    https://webrtc.googlesource.com/src.git/+/8155227/#F0
    Chrome may plan on sending both rtcp-fb:* and rtcp-fb:<int> variants for
    some time to allow migration in downstream projects.
    This change correctly parses the wildcard case to add the feedback to
    all payload types found in the SDP, to maintain compatibility with Pion.
    
    Resolves pion#172
    thebongy authored and Sean-Der committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    b7d0ec1 View commit details
    Browse the repository at this point in the history