Fix maximum packet count handling #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 76.31% // Head: 76.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 76.31% 76.56% +0.24%
==========================================
Files 17 17
Lines 1220 1233 +13
==========================================
+ Hits 931 944 +13
Misses 198 198
Partials 91 91
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
at-wat
force-pushed
the
fix-max-packet-handling
branch
from
ea18234
to
6764b45
Compare
Accoring to RFC3711 section 9.2, SRTP/SRTCP session must not wrap SRTP ROC and SRTCP index without changing the master key. Also fix Context.SetROC() with ROC>0xffff.
at-wat
force-pushed
the
fix-max-packet-handling
branch
from
6764b45
to
66c2660
Compare
at-wat
commented
Dec 21, 2022
| s.index = uint64(roc<<16) | (s.index & (seqNumMax - 1)) | ||
| s.index = uint64(roc)<<16 | (s.index & (seqNumMax - 1)) |
There was a problem hiding this comment.
Fix SetROC() with roc>0xffff
|
Going to merge this but feel free to add comments later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accoring to RFC3711 section 9.2, SRTP/SRTCP session must not wrap SRTP ROC and SRTCP index without changing the master key.
ref: https://www.rfc-editor.org/rfc/rfc3711#section-9.2