Move URI type from pion/ice to pion/stun #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
===========================================
- Coverage 98.16% 58.21% -39.95%
===========================================
Files 19 18 -1
Lines 1577 1716 +139
===========================================
- Hits 1548 999 -549
- Misses 23 684 +661
- Partials 6 33 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
stv0g
force-pushed
the
url
branch
3 times, most recently
from
8bb4109
to
73f2585
Compare
This was referenced Feb 24, 2023
stv0g
force-pushed
the
url
branch
2 times, most recently
from
c5c6a03
to
627cdbc
Compare
|
This change currently breaks the API of the module. As we are still with v0, I dont think this is a huge deal. The breaking changes are also really minor.. |
edaniels
requested changes
May 5, 2023
This makes it easier for users of pion/stun or pion/turn packages to handle URLs. Next step, would be to remove the URL type from pion/ice
Depending on the schema and transport, this function establishes also encrypted connections via TLS/DTLS.
Until now, TLS and DTLS backed STUN clients did not use a custom transport.Net.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the URL type from the pion/ice module to pion/stun and renames it to URI.
Hence this module gains full support for RFC7064 and RFC7065 (see #65).
The PR also adds a new function
stun.DialURI(u *stun.URI, cfg *stun.DialConfig)which create the underlying connection for the client for you based on the URI Scheme and transport protocol. Hence it can also use thedtlsandtlsmodules to establish an encrypted connection.Currently, the connection establishment is done by hand in various places:
This is also related to #35 (comment)
Furthermore, we now fully support passing a custom
transport.Netfor testing which was previously not supported for TLS / DTLS connections.