Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more than one static IP addresses #33

Merged
merged 3 commits into from
Aug 22, 2019
Merged

Allow more than one static IP addresses #33

merged 3 commits into from
Aug 22, 2019

Conversation

enobufs
Copy link
Member

@enobufs enobufs commented Aug 19, 2019

Resolves #32
See #32 for details.

@enobufs enobufs self-assigned this Aug 19, 2019
@codecov-io
Copy link

codecov-io commented Aug 19, 2019

Codecov Report

Merging #33 into master will increase coverage by 0.4%.
The diff coverage is 85.29%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #33     +/-   ##
========================================
+ Coverage    81.8%   82.2%   +0.4%     
========================================
  Files          15      15             
  Lines        1407    1422     +15     
========================================
+ Hits         1151    1169     +18     
+ Misses        177     176      -1     
+ Partials       79      77      -2
Impacted Files Coverage Δ
vnet/net.go 76.69% <70%> (-0.42%) ⬇️
vnet/router.go 81.29% <91.66%> (+2.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b74bc6...b3a4a67. Read the comment docs.

@enobufs enobufs changed the title Allow more than one static IP addresses [WIP] Allow more than one static IP addresses Aug 19, 2019
@enobufs
Copy link
Member Author

enobufs commented Aug 19, 2019

I will add more test to increase coverage.

@enobufs enobufs changed the title [WIP] Allow more than one static IP addresses Allow more than one static IP addresses Aug 20, 2019
vnet/net.go Show resolved Hide resolved
@enobufs enobufs merged commit a27a8ec into master Aug 22, 2019
@enobufs enobufs deleted the issue-32 branch August 22, 2019 00:50
@enobufs
Copy link
Member Author

enobufs commented Aug 22, 2019

Thanks @hugoArregui !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vnet: Allow assigning more than one static IP address
3 participants